So apple is retiring a photo editing software product and expects their customers to switch to their cloud photo editing service. They're replacing images stored locally with images stored externally.
Ignoring Snowden and the NSA for the moment, let's look at LEGAL seizure of your pictures to be used as evidence by government agencies, in rule enforcement, investigation, and criminal prosecution.
Not only are files under your physical control y'harder to get to physically than those transmitted over the Internet and stored in a vendor's server farm, they're also on better legal ground. The Supreme Court seems bent on treating electronic files, under your control, just like paper files locked in a safe at home. Just three days ago they ruled that police can't even search information stored on a cellpone carried by an arrestee without first coming up with probable cause and obtaining a warrant.
The last I heard, though, they considered information you stored on some vendor's servers to have been disclosed - that you have "no expectation of privacy" with respect to it. The police can go fishing through it just by asking, without jepoardizing prosecutions that result from what they fiind. Even if the third party cloud service demands paperwork rather than just giving access, a company like Apple has far less interest in protecting your data from fishing expeditions than you do.
Given the rat's nest of laws in the US, the prevalance of false or mistaken prosecutions, and the deliberate use of the legal and tax systems to punish those disliked by those in power (at all levels), I'd think nio sane person would put any personal information onto a cloud service (without at least encrypting it locally first with a key unknown to the service), let alone in a form that could be manipulated on the service. Photos are a particular risk, for a number of reasons I don't think I need to enumerate.
So I'd think that, both for personal use and for professional photographers, the substitution of a cloud service for a local tool working on locally stored data, would be unacceptable.