Personally I say he is both a hero and a traitor at the same time.
I'll take it a step further and state that the blonde bimbo should be tried on charges of attempted genocide.
I've told other people that as a conservative, my take on many of the issues you listed is that someone who supports limited government should have no problems with allowing gay marriage, with treating pot just like alcohol. Of course then as far as the tea baggers go, I go off the deep end. I do support taxation, and not only taxation, but progressive taxes that look at more than income.
Snowden committed civil disobedience. Which means he did break the law, but it was his moral duty to do so. He still needs to be held responsible for his actions.