Upgrading from Windows 7/8/XP/Vista to 10 is a no brainer. More features, better security, greater cloud integration to save all those files online instead of on some USB you'll end up losing.
Yes the HARDCORE FOLKS will cry "SECURITY! MALWARE! INVASION OF PRIVACY!!11!" and more nonsense. The average person who asks me if they should upgrade I say yes.
For the gamer person the addition of integrated video recording of games, nice slick update process, and Xbox syncronization are a win/win. If you are a die hard Playstation person who loves Windows 7, no reason to switch.