2) He said the review process is nonsensical and hostile. Not that the requirements are nonsensical and absurd.
But that's just, like, his opinion. To a flat earther, a globe is hostile. To an anti-vaxxer, vaccine mandates are hostile. To JD Vance, the facts are hostile.
3) already debunked
No, not debunked. It kinda proves my point, in fact. Anyone that's dealt with the AMO team knows that the team goes through thousands of submissions a day. I'm pretty sure the submissions page itself says so as that's what I know from dealing with them. Like, on one of my add ons, I have to write a justification EVERY TIME I submit a new version because I'm using
.innerHTML. They literally state that they don't have time to read through and scrutinize every file and line. If you want your stuff to pass easily, make it easy to read, understand and pass. Again, I'm pretty sure the submissions page and/or the guidelines page says this explicitly. This could have been solved with just him renaming the files or folder to something like "google-ad-string-utilities.js"
4) "None of these files are commented or documented." Well true, and while that could have lead the review to the right conclusion, there is no requirement on commenting or documenting the code, so the point is irrelevant.
No, not irrelevant. Again, anyone that's read the guide or the security protocols for submission of add-ons to AMO knows that the easier it is for them to read and understand the code, the easier it'll be for your add-ons to pass. At least once or twice, one of my add-ons were flagged erroneously for something and they went "Can you explain this?" And I wrote back "It's because of this, as per the comments on that function." And then they approved it and it has never been a problem since.
5) "Well if there is a photo of a beach and they say "this picture contains violence", how do you say where specifically they are wrong if they don't elaborate themselves?"
This misses the point completely. When the AMO team goes, "There's something wrong", they tell you which file. The author knows which file because they told him. And in a review like that where they find a problem, they'll go "We have a problem with these files. Why are they there? What's the justification for them?" And, my point is, they're not looking for the answer of "Well, they're here." They're looking for the answer of "Here's why these files exist." Just going "These files exist" tells the reviewer nothing. As to "They should understand code", that's answered in "Anyone that's dealt with the AMO team knows that the team goes through thousands of submissions a day. I'm pretty sure the submissions page itself says so as that's what I know from dealing with them."
Just because it's someone job to clean the floors, doesn't mean you should throw all your food on the floor when you feel like it.
6. Well there is also not machine-generatednor concatenated code either.
What AmiMoJo said.
"I don't know what kind of email exchange there was, and how frequent this kind of behavior from Mozilla has been.?
AMO sends responses via the add-ons/developer portal. That sends an automated email out. You can email reply back, but it goes back to AMO via the ticketing system. In fact, it's easier to keep track via their portal.
"The developer could have done some things a bit differently for this to go more smoothly, but to restate, the point is that he really should not have had to."
As a developer, YOU're asking to get on to THEIR system/platform. If you're asking to go into someone's house and they go "Hey, can you make sure your shoes don't track mud when you come in?" You shouldn't get mad if they stop you when your clothes was painted to look like it was covered in mud. Like, think about this as if you were reviewing a pull request. If you suddenly see new folder with a bunch of files named "Mozilla-ads.js" and "google-analytics.js", none of the code is commented, when asking for a clarification/explanation, you get "These files are here." instead of an explanation, you would reject the pull request too.
"Also, Mozilla could have started by asking for more information, not by making bogus claims."
They do. You're just seeing the last response from AMO that the author has posted.
"In the current state, if I were Mozilla, I would try very hard to not alienate developers."
That's exactly the line a lot of crypto mining/malware add-ons that were disguised as something else said. That's also why there were/are more add-ons that were hidden malware, scams, etc. on google's web store than on the mozilla one. Like, all the things/rules/procedures the author is complaining about? Those came about as a response to this:
https://yro.slashdot.org/story...
and this:
https://yro.slashdot.org/story...
and this:
https://it.slashdot.org/story/...
and this:
https://tech.slashdot.org/stor...
and this:
https://tech.slashdot.org/stor...
Notice how all of those are focused on the google web store. Those impacts were much less, if at all, on the Mozilla side. It's only been 3 years. Do you not remember?
But also, have you see the changes manifest v3 requires you to make on the chrome side? I've stopped updating my add-ons on the chrome side because of all the hassle. Not to mention chrome, and even chromium is getting worse. I've recently switched back to a mozilla variant because of it and have had less problems.
Again, I'm not saying saying AMO team never make mistakes. But if you're walking around dressed like a duck, you shouldn't be mad when someone calls you a duck.