Comment Re:What does this code do? (Score 1) 444
It unnecessarily runs the first three lines of code before checking a condition it could just as well check right at the start. You're right that it is clear that it is modelling a state machine, but it is doing it in a way that is concerned with the fact that is a state machine, rather than a representation of something which happens to be a state machine.
If I'd written that piece of code, I wouldn't love to bring it up at all. I'd blow up the source control server and deny all knowledge.