X-Plane's biggest problem now is lack of scenery. Everything is in place for it to be premier - Terrain, planes, flight model accuracy, etc. But there's still quite limited "landmark" scenery, and a lot of the best is payware. MSFS has had, for a good couple decades now, readily available scenery for major cities with all sorts of recognizable landmarks and every release has added more. I still fly X-Plane a ton more, but I still fire up MSFS when I want to do some sight-seeing. It's really the last thing holding back X-Plane.
I've also been involved in the X-P community for awhile now, and the lead author, Austin Meyer, can be a bit... eccentric, in a Jobsian sort of way.