I am looking at a stored PROCEDURE as it takes too long to run. Besides the CURSORs, DECODE()s where NVL() should be used, and a UNION, there exists this stupidity up front:
csSpace CONSTANT CHAR(1)
cnZero CONSTANT NUMBER(1)
How many things can you spot that is just plain wrong with that?
- It uses the misunderstanding of Hungarian notation.
- It uses Hungarian notation for a constant
- The constant is not an uppercase
- The contant says what its value is, as opposed to it itself is
- It uses CHAR(1) (In Oracle VARCHAR2 there is no benefit to CHAR over VARHAR2)
Why is it that good programmers exist only in forums and newgroups, but not in the real world?