My personal opinion of the person is that is he cracked in the head; homosexual or not. And while I do feel that he failed in his duty and honor I don't think he was in a fit state of mind. Those that put such a nut in such a position of responsibility should be held accountable for dereliction of duty. When I first herd his story I felt he was a dishonorable solider but a contentious american but now I realize believe he was a cracked nut to begin with and the military just added heat and made pop-corn.
But lets just assume he qualifies as being criminally rational at the time he did the things he did. When I think of spying or being a traitor I think of it being for the purpose of specifically benefiting another group or groups. One such group could of course be himself if he could expect some significant benefit such as money. But I don't see any of that here. He didn't pass along information in private that could benefit a foreign power. Some may even say that what he made public helped Islamist's in the middle east in their revolutions; those most opposed to his own political leanings.
I think some distinction much be made between a cracked contentious whistle blower that tarnishes his honor by not keeping his mouth shut and a true traitor that in his position could have done far more damage.