I think half of you points are invalid. The planned failure is a mere rumor, I would think. Is there any proof for that? From my experience, Apple hardware has about the same failure rate as other manufacturers. We have dozens of Apple devices in use, besides dozens of other manufacturer's laptops, workstations, servers and assorted hardware. iMac, MBP, iPod, iPhone, iPad... My work laptop is a MBP from late 2008. It is now 3.5 years old, has traveled with me for thousands of miles, seen every day use (as in 8hrs / day). And apart from the battery being replaced after three years, the thing is happily working and very, very sturdy. The same goes for our other Apple laptops. The iPod Touch (2nd gen) are also now quite old and are still in use for coding and teaching.
And again, Apple should not be singled out when it comes to Carrier IQ and the GPS story. The same problems persist(ed?) on numerous other smartphones as well. The GPS flaw was fixed very quickly and the Carrier IQ version that once came with iOS was not sending keystrokes and similar stuff, as seemed to happen on other platforms. Since iOS 5 this piece of the software has been removed anyway. I think it is a good thing that the community takes a close look at Apple's releases, and that flaws like this get mentioned. The downside is of course that fixes might take some time to get incorporated, if we are unlucky. Compared to pure Open Source systems, I cannot easily patch my iPhone (although I heard some fixes make it into Cydia quite quickly).
The walled garden argument is a weak one. Apple's goal was to make the software platform of iOS a rather secure one, and their solution is the iOS developer program. This system is a system of trust, and it means that software developed for iOS comes from a trusted source (you, the developer). I think this is a good idea. To fund this system, one pays 79 EUR per year, and if you do so, you can use the whole toolchain of Apple's development framework to do whatever you like on your iPhone. If you don't want to do that, it's fine. You can wait for the latest Jailbreak to be released. The frameworks and APIs are well documented and in that sense quite open (yes, many things are not free as in speech, but many other things on iOS are).