The beer-free tools for PCB creation have become incredibly good recently, with the exception of autorouting which is still not so great at the inexpensive end of the market.
Small-quantity PCB services are ridiculously inexpensive at often only a few dollars per board, delivered.
Component pitch has shrunk to the point that making fine lines for most chips is really hard with hobbyist etching tools. Forget vias.
So when are DIY PCBs useful? Maybe with single-sided surface mount boards that have medium-pitch components when board quality isn't so important, and you need it in hours, not days-to-weeks.
When does that happen? Never, for me. Really, never.
Add in the storage and surface areas required for the chemicals and processing, the setup/cleanup time, the toxicity of the chemicals, and there's a very good reason I have not ever, not once, even considered making my own PCB.
When I need to prototype circuits, point-to-point works really well, and using SMT adapters that are also ridiculously inexpensive. And even then, the battles you have to wage with noise coupled with the really inexpensive costs of professionally-made boards make it almost not worth constructing point-to-point (and in my experience, breadboards universally suck).
So should you make your own PCBs? If the making of the PCB isn't an end until itself for the pleasure of constructing the board, then the answer is, "no." If you like playing with resist layers, electroetch, and stuff like that, then sure. I mean, you could wind your own resistors, too, if you really wanted to. And there's a fellow who makes his own tubes, too (he's amazing, and I admire the skill). But buy your PCBs, don't make them.