I didn't mean that you said it eliminated all risks. I meant that there wasn't even one risk that was eliminated (though perhaps some were reduced). Unless you're building your own computers from components that you manufactured, you're making your own operating system, you're making your own bitcoin software, and so on, you are taking on third party risk that cannot be eliminated because you're accepting and using security-critical components developed by third parties. Unless you are literally generating your key by pencil-and-paper calculation (which is not the normal way of doing things by the design of bitcoin because it raises the risks of insufficient randomness and human error), your offline wallet's key was almost surely on a computer and an operating system that might have been compromised while the key was present or the system might not have deleted it.
All transactions being recorded may be a feature, but it still greatly reduces the strength of your argument about spying, particularly when statistical analyses are used.
It may happen that if bitcoin changes due to legal pressure, people will move to other currencies, but there are a lot of reasons not to assume that's a sure thing. Bitcoin will already have been established and working which will reduce the drive to switch, the risk of such a thing happening again will dampen enthusiasm, the newly-explicit lack of legal legitimacy (which hampered bitcoin growth) will hamper growth, and there's a high chance that alternatives will be permanently stuck with just about only enthusiasts as users.