Comment Re:If they want to reduce pollution (Score 5, Funny) 211
Because cars are awesome, hippy.
Because cars are awesome, hippy.
I can't figure out if I'm the only sane one or the only crazy one. Especially given the 'pyramid' referred to - I don't see a pyramid unless it's rewritten to use nested ifs.
To me, nested ifs are much easier to read - they convey the meaning/intent of the code a lot better. As in 'if this function call works, then do this. Otherwise, just clean up and exit'
How is this so hard to understand?
geode_aes_probe(struct pci_dev *dev, const struct pci_device_id *id) {
int ret;
if ((ret = pci_enable_device(dev)))
return ret;
if (!(ret = pci_request_regions(dev, "geode-aes"))) {
_iobase = pci_iomap(dev, 0, 0);
if (_iobase == NULL) {
ret = -ENOMEM;
}
else {
spin_lock_init(&lock);
iowrite32(AES_INTR_PENDING | AES_INTR_MASK, _iobase + AES_INTR_REG);
if (!(ret = crypto_register_alg(&geode_alg))) {
if (!(ret = crypto_register_alg(&geode_ecb_alg))) {
if (!(ret = crypto_register_alg(&geode_cbc_alg))) {
printk(KERN_NOTICE "geode-aes: GEODE AES engine enabled.\n");
return 0;
}
crypto_unregister_alg(&geode_ecb_alg);
}
crypto_unregister_alg(&geode_alg);
}
pci_iounmap(dev, _iobase);
}
pci_release_regions(dev);
}
pci_disable_device(dev);
printk(KERN_ERR "geode-aes: GEODE AES initialization failed.\n");
return ret;
}
Mods, please look up the meaning of the word 'informative'. I do not think it means what you think it means.
His point is that a 13-character password is harder to crack than a 3 character one, and if he put the spaces there to make the password harder to crack, removing them will make the password (possibly much) weaker.
It is easier to write an incorrect program than understand a correct one.